Page MenuHomePhabricator
Differential D3720

Pass WalletModel down to SendCoinsEntry by construct
ClosedPublic
Actions

Authored by deadalnix on Jul 23 2019, 16:53.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING876ddfaff7c9: Pass WalletModel down to SendCoinsEntry by construct
rABC876ddfaff7c9: Pass WalletModel down to SendCoinsEntry by construct
Summary

This ensures the wallet model is passed down in constructors so that the SendCoinsEntry has it right away.

Test Plan
make check

Make sure the ubsan build is now fixed.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixubsan
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6923
Build 11893: Bitcoin ABC Buildbot (legacy)
Build 11892: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 23 2019, 16:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2019, 16:53
teamcity added a comment.Jul 23 2019, 16:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B6923: Diff 10406.Jul 23 2019, 16:59
teamcity added a comment.Jul 23 2019, 16:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix retitled this revision from Pass WalletModel down to SendCoinsEntry y construct to Pass WalletModel down to SendCoinsEntry by construct.Jul 23 2019, 17:43
jasonbcox requested changes to this revision.Jul 23 2019, 18:38
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/sendcoinsdialog.cpp
143

nit: this comment isn't useful

src/qt/sendcoinsentry.cpp
102

This doesn't appear to depend on the options model.

This revision now requires changes to proceed.Jul 23 2019, 18:38
deadalnix added inline comments.Jul 23 2019, 23:18
src/qt/sendcoinsdialog.cpp
143

Yes, the model has been set, but there are triggers that need to run when it is set which have not run yet.

src/qt/sendcoinsentry.cpp
102

Good catch.

deadalnix updated this revision to Diff 10413.Jul 23 2019, 23:20

Update SendCoinsEntry::setModel

teamcity added a comment.Jul 23 2019, 23:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jul 23 2019, 23:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6927: Diff 10413.Jul 23 2019, 23:27
jasonbcox accepted this revision.Jul 24 2019, 00:45
This revision is now accepted and ready to land.Jul 24 2019, 00:45
Closed by commit rABC876ddfaff7c9: Pass WalletModel down to SendCoinsEntry by construct (authored by deadalnix). · Explain WhyJul 24 2019, 12:32
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC876ddfaff7c9: Pass WalletModel down to SendCoinsEntry by construct.
Fabien mentioned this in D3650: Fix null pointer dereference in SendCoinsEntry.Jul 25 2019, 09:11
deadalnix added a commit: rSTAGING876ddfaff7c9: Pass WalletModel down to SendCoinsEntry by construct.Sep 19 2019, 01:23

Revision Contents
Changeset List

Diff 10406

View Options

src/qt/sendcoinsdialog.h

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/qt/sendcoinsentry.h

Loading...
View Options

src/qt/sendcoinsentry.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/qt/walletframe.cpp

Loading...
View Options

src/qt/walletview.h

Loading...
View Options

src/qt/walletview.cpp

Loading...