Differential D3783

Fix -Wthread-safety-analysis warnings
ClosedPublic
Actions

Authored by Fabien on Jul 31 2019, 12:47.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGa06190889362: Fix -Wthread-safety-analysis warnings
rABCa06190889362: Fix -Wthread-safety-analysis warnings

Summary

Add missing locks and annotations to get rid of the -Wtrhead-analysis
warnings.

Test Plan

With Clang:

make check
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_thread_analysis_warnings

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7015
Build 12077: Bitcoin ABC Buildbot (legacy)
Build 12076: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 31 2019, 12:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2019, 12:47

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7015: Diff 10543!Jul 31 2019, 12:47

Rebase

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7017: Diff 10545.Jul 31 2019, 13:10

deadalnix accepted this revision.Aug 2 2019, 00:08

This revision is now accepted and ready to land.Aug 2 2019, 00:08

Closed by commit rABCa06190889362: Fix -Wthread-safety-analysis warnings (authored by Fabien). · Explain WhyAug 2 2019, 07:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa06190889362: Fix -Wthread-safety-analysis warnings.

Fabien added a commit: rSTAGINGa06190889362: Fix -Wthread-safety-analysis warnings.Sep 19 2019, 01:32

Revision Contents
Changeset List

Path

Size

src/

miner.h

5 lines

test/

mempool_tests.cpp

2 lines

Diff 10543

View Options

src/miner.h