HomePhabricator

MINIMALDATA consensus activation

Description

MINIMALDATA consensus activation

Summary:
This converts MINIMALDATA from standard to consensus for the Nov 2019
upgrade. The behaviour of MINIMALDATA and the reasons for activation
are described here: https://github.com/bitcoincashorg/bitcoincash.org/pull/376

Test is based on D3736 but doesn't test upgrade deactivation since this is
a strict soft-fork.

Note that in validation.cpp CheckInputs, mandatoryFlags never includes
MINIMALDATA so minimaldata violations always appear as "non-mandatory-...",
even after the upgrade, not as "upgrade-conditional-...".

Depends on D3736 (though unrelated, the code overlaps slightly).

Test Plan:
make check
test_runner.py
test_runner.py --extended --with-gravitonactivation

Reviewers: deadalnix, #bitcoin_abc, Mengerian

Reviewed By: deadalnix, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3763

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on Jul 29 2019, 18:12
markblundebergPushed on Aug 2 2019, 01:09
Reviewer
Restricted Project
Differential Revision
D3763: MINIMALDATA consensus activation
Parents
rABC2a1e1d244b1b: New Schnorr multisig activation
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC38d64b15884b: MINIMALDATA consensus activation (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).Aug 2 2019, 01:09