Page MenuHomePhabricator

New Schnorr multisig activation
ClosedPublic

Authored by markblundeberg on Jul 25 2019, 05:29.

Details

Reviewers
deadalnix
Mengerian
jasonbcox
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rSTAGING2a1e1d244b1b: New Schnorr multisig activation
rABC2a1e1d244b1b: New Schnorr multisig activation
Summary

Based on D2483, but the functional test uses the new features recently
introduced (see current abc-schnorr.py).

Depends on D3474

Test Plan

make check
test_runner.py
test_runner.py --with-gravitonactivation

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Hmm, I tried also running ./test/functional/test_runner.py --with-gravitonactivation which actually causes a failure in feature_nulldummy.py, which is not surprising because the reject reason will have changed.

markblundeberg edited the test plan for this revision. (Show Details)

update feature_nulldummy test to only run pre-activation

test/functional/feature_nulldummy.py
29 ↗(On Diff #10505)

Alternatively, we can just delete this test now since the test cases seem to be covered by abc-schnorrmultisig-activation.py anyway.

rebase onto the updated parent

test/functional/abc-schnorrmultisig-activation.py
88 ↗(On Diff #10517)

this can be removed (leftover from copy)

deadalnix added inline comments.
test/functional/abc-schnorrmultisig-activation.py
224 ↗(On Diff #10517)

You probably want to have an else that throw an error.

This revision is now accepted and ready to land.Aug 2 2019, 00:36
markblundeberg added a task: Restricted Maniphest Task.Aug 9 2019, 19:20