Page MenuHomePhabricator

MINIMALDATA consensus activation
ClosedPublic

Authored by markblundeberg on Jul 29 2019, 21:10.

Details

Summary

This converts MINIMALDATA from standard to consensus for the Nov 2019
upgrade. The behaviour of MINIMALDATA and the reasons for activation
are described here: https://github.com/bitcoincashorg/bitcoincash.org/pull/376

Test is based on D3736 but doesn't test upgrade deactivation since this is
a strict soft-fork.

Note that in validation.cpp CheckInputs, mandatoryFlags never includes
MINIMALDATA so minimaldata violations always appear as "non-mandatory-...",
even after the upgrade, not as "upgrade-conditional-...".

Depends on D3736 (though unrelated, the code overlaps slightly).

Test Plan

make check
test_runner.py
test_runner.py --extended --with-gravitonactivation

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.