Page MenuHomePhabricator
Differential D3736

New Schnorr multisig activation
ClosedPublic
Actions

Authored by markblundeberg on Jul 25 2019, 05:29.

Details

Reviewers
deadalnix
Mengerian
jasonbcox
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics)
Commits
rSTAGING2a1e1d244b1b: New Schnorr multisig activation
rABC2a1e1d244b1b: New Schnorr multisig activation
Summary

Based on D2483, but the functional test uses the new features recently
introduced (see current abc-schnorr.py).

Depends on D3474

Test Plan

make check
test_runner.py
test_runner.py --with-gravitonactivation

Diff Detail

Repository
rABC Bitcoin ABC
Branch
activateschnorr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6991
Build 12029: Bitcoin ABC Buildbot (legacy)
Build 12028: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 25 2019, 05:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2019, 05:29
teamcity added a comment.Jul 25 2019, 05:29

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a comment.Jul 25 2019, 05:32

Hmm, I tried also running ./test/functional/test_runner.py --with-gravitonactivation which actually causes a failure in feature_nulldummy.py, which is not surprising because the reject reason will have changed.

teamcity added a comment.Jul 25 2019, 05:35

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B6957: Diff 10462!Jul 25 2019, 05:36
markblundeberg planned changes to this revision.Jul 25 2019, 05:42
markblundeberg updated this revision to Diff 10505.Jul 26 2019, 21:12
markblundeberg edited the test plan for this revision. (Show Details)

update feature_nulldummy test to only run pre-activation

teamcity added a comment.Jul 26 2019, 21:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added inline comments.Jul 26 2019, 21:13
test/functional/feature_nulldummy.py
29 ↗(On Diff #10505)

Alternatively, we can just delete this test now since the test cases seem to be covered by abc-schnorrmultisig-activation.py anyway.

teamcity added a comment.Jul 26 2019, 21:23

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6983: Diff 10505.Jul 26 2019, 21:23
markblundeberg updated this revision to Diff 10517.Jul 29 2019, 18:04

rebase onto the updated parent

teamcity added a comment.Jul 29 2019, 18:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B6991: Diff 10517.Jul 29 2019, 18:13
teamcity added a comment.Jul 29 2019, 18:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

markblundeberg added inline comments.Jul 29 2019, 18:54
test/functional/abc-schnorrmultisig-activation.py
88

this can be removed (leftover from copy)

markblundeberg added a child revision: D3763: MINIMALDATA consensus activation.Jul 29 2019, 21:10
deadalnix accepted this revision.Aug 2 2019, 00:36
deadalnix added inline comments.
test/functional/abc-schnorrmultisig-activation.py
224

You probably want to have an else that throw an error.

This revision is now accepted and ready to land.Aug 2 2019, 00:36
Closed by commit rABC2a1e1d244b1b: New Schnorr multisig activation (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyAug 2 2019, 01:03
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC2a1e1d244b1b: New Schnorr multisig activation.
markblundeberg added a task: T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics).Aug 9 2019, 19:20
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING2a1e1d244b1b: New Schnorr multisig activation.Sep 19 2019, 01:32
tobias_ruck mentioned this in D5130: OP_REVERSEBYTES activation logic.Feb 2 2020, 18:19
tobias_ruck mentioned this in rABCfcf22e8fcc94: OP_REVERSEBYTES activation logic.Feb 12 2020, 07:11
tobias_ruck mentioned this in D5283: OP_REVERSEBYTES activation logic.Feb 13 2020, 03:05
tobias_ruck mentioned this in rABC9bd868e48eb0: OP_REVERSEBYTES activation logic.Feb 13 2020, 05:34
tobias_ruck mentioned this in rSTAGING9bd868e48eb0: OP_REVERSEBYTES activation logic.Apr 7 2020, 22:59
tobias_ruck mentioned this in rSTAGINGfcf22e8fcc94: OP_REVERSEBYTES activation logic.

Revision Contents
Changeset List

PathSize
src/
32 lines
test/
functional/
393 lines
9 lines

Diff 10517

View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-schnorrmultisig-activation.py

Loading...
View Options

test/functional/feature_nulldummy.py

Loading...