Page MenuHomePhabricator
Differential D3782

rpcauth: Improve by using argparse and getpass modules
ClosedPublic
Actions

Authored by Fabien on Jul 31 2019, 09:39.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING03b30a8c3682: rpcauth: Improve by using argparse and getpass modules
rABC03b30a8c3682: rpcauth: Improve by using argparse and getpass modules
Summary
This PR improves argument handling in rpcauth.py script by using
argparse module. Specifying - as password makes it prompt securely with
getpass module which prevents leaking passwords to bash history.

Backport of core PR14756
https://github.com/bitcoin/bitcoin/pull/14756/files

Depends on D3781.

Also updated the copyright so the file is in sync with core.

Test Plan
make check

./share/rpcauth/rpcauth.py foo --help

Check help is displayed correctly.

./share/rpcauth/rpcauth.py foo -

Check the script asks for password.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
share/
rpcauth/
16 lines
41 lines

Diff 10596

View Options

share/rpcauth/README.md

Loading...
View Options

share/rpcauth/rpcauth.py

Loading...