Because of the replay protection, a lot of RPC tests do not function as expected post fork. This update several of them by putting the fork activation time far away in the past, essentially making the fork always on.
Details
Details
- Reviewers
freetrader CCulianu - Group Reviewers
Restricted Project - Commits
- rSTAGINGf8e3ae62e07f: Update several rpc tests to work post fork.
rABCf8e3ae62e07f: Update several rpc tests to work post fork.
Run the tests
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- fixmoretests
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 672 Build 672: arc lint + arc unit
Event Timeline
Comment Actions
Ok, as per @freetrader 's comment in another diff -- you gotta apply these all together.
@deadalnix -- in the future please either set up dependencies properly in the diffs or rebase or something. It took me extra work to figure out that this diff depends on other diffs to apply cleanly.
Also, I suggest if you have a set of related changes that all depend on each other anyway, *please submit them as 1 or 2 larger diffs*. There is no point in doing "small incremental changes" when they all depend on each other anyway. It creates chaos and is error-prone. I spent a good 20 minutes scratching my head until @freetrader informed me they are all related and they need to be applied in a non-obvious order.
Anyway, with all these diffs together:
- rpc-tester.py tests (wiithout -extended) all PASS.
- rpc-tester.py -extended tests: maxuploadtarget fails with error: JSONRPC error: 64: non-mandatory-script-verify-flag (Illegal use of SIGHASH_FORKID) -- all other tests PASS