Page MenuHomePhabricator

[teamcity/gitian] Do not remove src tarball from results
ClosedPublic

Authored by jasonbcox on Aug 13 2019, 00:41.

Details

Summary

Reasons to delete the src tarball:

  • Save disk space

Reasons to keep it:

  • Easily package a release from TeamCity (if needed)
  • Verify and/or manually test the src tarball.
  • TeamCity automatically cleans up old build artifacts, so disk space is not really an issue.

I'm in favor of keeping it.

Test Plan

TeamCity gitian build (see comments)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gitian-src
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7130
Build 12306: Bitcoin ABC Buildbot (legacy)
Build 12305: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 13 2019, 07:40