Merge #12779: Qt: Remove unused method setupAmountWidget(...)
ClosedPublic
Actions

Authored by nakihito on Aug 17 2019, 00:22.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING5c5a7fe37a30: Merge #12779: Qt: Remove unused method setupAmountWidget(...)
rABC5c5a7fe37a30: Merge #12779: Qt: Remove unused method setupAmountWidget(...)

Summary

3a0f8d7 Qt: Remove unused method setupAmountWidget(...) (practicalswift)

Pull request description:

Remove unused method `setupAmountWidget(...)`.

Last use removed in f193c57a63d8e66835873ff05ef8028fa87b427f.

Tree-SHA512: 8f25ed2da13cfbc0f2e042286b3c979ef03de960028d7824110bdc2ed96f5075e3b35a9809a09c83caa5bad2237d2e048ff212b19a0be1d07f79c19691dfcd87

Backport of Core PR12779
https://github.com/bitcoin/bitcoin/pull/12779/

Test Plan

make check
./bitcoin-qt -> send and receive transactions, perform some console rpc commands, and search transactions

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12779

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7180
Build 12405: Bitcoin ABC Buildbot (legacy)
Build 12404: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 17 2019, 00:22

Owners added a reviewer: Restricted Owners Package.Aug 17 2019, 00:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2019, 00:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7180: Diff 10849.Aug 17 2019, 00:40

Please run some sanity checks on bitcoin-qt as part of the test plan.

src/qt/guiutil.h
56	The comment change is missing.

This revision now requires changes to proceed.Aug 19 2019, 06:25

Fixed comment.

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Aug 19 2019, 22:39

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7197: Diff 10876.Aug 19 2019, 22:44

Fabien accepted this revision.Aug 20 2019, 07:23

This revision is now accepted and ready to land.Aug 20 2019, 07:23

Closed by commit rABC5c5a7fe37a30: Merge #12779: Qt: Remove unused method setupAmountWidget(...) (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 20 2019, 17:02

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC5c5a7fe37a30: Merge #12779: Qt: Remove unused method setupAmountWidget(...).

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING5c5a7fe37a30: Merge #12779: Qt: Remove unused method setupAmountWidget(...).Sep 19 2019, 01:56

Revision Contents
Changeset List

Path

Size

src/

qt/

guiutil.h

1 line

guiutil.cpp

8 lines

Diff 10849

View Options

src/qt/guiutil.h