Merge #12787: rpc: Adjust ifdef to avoid unreachable code
ClosedPublic
Actions

Authored by nakihito on Aug 17 2019, 00:54.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGfa8d487a9fbd: Merge #12787: rpc: Adjust ifdef to avoid unreachable code
rABCfa8d487a9fbd: Merge #12787: rpc: Adjust ifdef to avoid unreachable code

Summary

61f8298 rpc: Adjust ifdef to avoid unreachable code (practicalswift)

Pull request description:

Adjust `ifdef` to avoid unreachable code.

Introduced in 1e79c055cd30d21ba5f8c7f81ef911d5d4e295a8.

Tree-SHA512: c775cc9181e4034f26c5b219974e06886435275933249b169d2bc8bc98f639c4027e1e7d991f43bded62146a141acee6d3be1f2b313042d9bbc0a5d2e71d6c7c

Backport of Core PR12787
https://github.com/bitcoin/bitcoin/pull/12787/

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12787

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7183
Build 12411: Bitcoin ABC Buildbot (legacy)
Build 12410: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 17 2019, 00:54

Owners added a reviewer: Restricted Owners Package.Aug 17 2019, 00:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2019, 00:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7183: Diff 10852.Aug 17 2019, 01:01

jasonbcox accepted this revision.Aug 17 2019, 15:15

This revision is now accepted and ready to land.Aug 17 2019, 15:15

Closed by commit rABCfa8d487a9fbd: Merge #12787: rpc: Adjust ifdef to avoid unreachable code (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 19 2019, 18:12

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCfa8d487a9fbd: Merge #12787: rpc: Adjust ifdef to avoid unreachable code.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGfa8d487a9fbd: Merge #12787: rpc: Adjust ifdef to avoid unreachable code.Sep 19 2019, 01:54

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction.cpp

15 lines

Diff 10852

View Options

src/rpc/rawtransaction.cpp

Merge #12787: rpc: Adjust ifdef to avoid unreachable codeClosedPublicActions