Page MenuHomePhabricator
Differential D3922

Cleanup reject_code in abc-segwit-recovery
ClosedPublic
Actions

Authored by jasonbcox on Aug 20 2019, 21:03.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING482bedb0d69f: Cleanup reject_code in abc-segwit-recovery
rABC482bedb0d69f: Cleanup reject_code in abc-segwit-recovery
Summary

Cleanup related to backporting Core PR14119
https://github.com/bitcoin/bitcoin/pull/14119/files

Test Plan

test_runner.py abc-segwit-recovery

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14119-p9
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7210
Build 12465: Bitcoin ABC Buildbot (legacy)
Build 12464: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 20 2019, 21:03
Herald added a reviewer: deadalnix. · View Herald TranscriptAug 20 2019, 21:03
teamcity added a comment.Aug 20 2019, 21:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 20 2019, 21:12

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7208: Diff 10895.Aug 20 2019, 21:12
jasonbcox updated this revision to Diff 10897.Aug 20 2019, 22:03

Added missing bytes -> str

teamcity added a comment.Aug 20 2019, 22:03

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox added a child revision: D3924: Cleanup TODOs leftover from PR14119 backporting.Aug 20 2019, 22:11
teamcity added a comment.Aug 20 2019, 22:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7210: Diff 10897.Aug 20 2019, 22:21
Fabien accepted this revision.Aug 21 2019, 08:23
This revision is now accepted and ready to land.Aug 21 2019, 08:23
Closed by commit rABC482bedb0d69f: Cleanup reject_code in abc-segwit-recovery (authored by jasonbcox). · Explain WhyAug 21 2019, 15:33
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC482bedb0d69f: Cleanup reject_code in abc-segwit-recovery.
jasonbcox added a commit: rSTAGING482bedb0d69f: Cleanup reject_code in abc-segwit-recovery.Sep 19 2019, 01:58

Revision Contents
Changeset List

PathSize
test/
functional/
26 lines

Diff 10897

View Options

test/functional/abc-segwit-recovery.py

Loading...