Page MenuHomePhabricator
Differential D3930

trivial: Improve include comment in src/interfaces/wallet.h
ClosedPublic
Actions

Authored by fpelliccioni on Aug 21 2019, 18:16.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING613c7d202468: trivial: Improve include comment in src/interfaces/wallet.h
rABC613c7d202468: trivial: Improve include comment in src/interfaces/wallet.h
Summary

Backport of Bitcoin Core PR13026
https://github.com/bitcoin/bitcoin/pull/13026

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-test-backporting
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7217
Build 12479: Bitcoin ABC Buildbot (legacy)
Build 12478: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Aug 21 2019, 18:16
Owners added a reviewer: Restricted Owners Package.Aug 21 2019, 18:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 21 2019, 18:16
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 21 2019, 18:16

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 21 2019, 18:17

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni updated this revision to Diff 10914.Aug 21 2019, 18:23

Fix indentation

teamcity added a comment.Aug 21 2019, 18:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7217: Diff 10913.Aug 21 2019, 18:24
teamcity added a comment.Aug 21 2019, 18:24

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Aug 21 2019, 18:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7218: Diff 10914.Aug 21 2019, 18:32
Fabien requested changes to this revision.Aug 21 2019, 19:18

Please use PR12345 in the summary (no #) and use markdown to make the test plan look pretty.

src/interfaces/wallet.h
10 ↗(On Diff #10914)

Move the comment above #include <pubkey.h>

This revision now requires changes to proceed.Aug 21 2019, 19:18
deadalnix added inline comments.Aug 21 2019, 19:21
src/interfaces/wallet.h
10 ↗(On Diff #10914)

It's fine this way. clang-format handles is gracefully.

fpelliccioni edited the summary of this revision. (Show Details)Aug 22 2019, 12:30
fpelliccioni edited the test plan for this revision. (Show Details)
fpelliccioni marked 2 inline comments as done.
In D3930#92157, @Fabien wrote:

Please use PR12345 in the summary (no #) and use markdown to make the test plan look pretty.

Fixed and added the PR link to github.

src/interfaces/wallet.h
10 ↗(On Diff #10914)

I followed Amaury's recommendation.

fpelliccioni updated this revision to Diff 10923.Aug 22 2019, 13:25
fpelliccioni edited the summary of this revision. (Show Details)

Fixed Diff summary and test case.

teamcity added a comment.Aug 22 2019, 13:25

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 22 2019, 13:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7225: Diff 10923.Aug 22 2019, 13:33
Fabien accepted this revision.Aug 22 2019, 13:33
This revision is now accepted and ready to land.Aug 22 2019, 13:33
Closed by commit rABC613c7d202468: trivial: Improve include comment in src/interfaces/wallet.h (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by fpelliccioni). · Explain WhyAug 22 2019, 13:34
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC613c7d202468: trivial: Improve include comment in src/interfaces/wallet.h.
fpelliccioni added a commit: rSTAGING613c7d202468: trivial: Improve include comment in src/interfaces/wallet.h.Sep 19 2019, 01:58

Revision Contents
Changeset List

PathSize
src/
interfaces/
6 lines

Diff 10913

View Options

src/interfaces/wallet.h

Loading...