Page MenuHomePhabricator
Differential D3940

Merge #11131: rpc: Write authcookie atomically
ClosedPublic
Actions

Authored by nakihito on Aug 22 2019, 20:45.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe26ef4b479c4: Merge #11131: rpc: Write authcookie atomically
rABCe26ef4b479c4: Merge #11131: rpc: Write authcookie atomically
Summary

82dd719 rpc: Write authcookie atomically (Wladimir J. van der Laan)

Pull request description:

Use POSIX rename atomicity at the `bitcoind` side to create a working
cookie atomically:

- Write `.cookie.tmp`, close file
- Rename `.cookie.tmp` to `.cookie`

This avoids clients reading invalid/partial cookies as in #11129. As such, this is an alternative to that PR.

Tree-SHA512: 47fcc1ed2ff3d8fed4b7441e4939f29cc99b57b7a035673c3b55a124a2e49c8a904637a6ff700dd13a184be8c0255707d74781f8e626314916418954e2467e03

Backport of Core PR11131
https://github.com/bitcoin/bitcoin/pull/11131/

Test Plan
make check
./bitcoind

Verify .cookie exists ine .bitcoin/<dir>/.cookie

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11131
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7230
Build 12505: Bitcoin ABC Buildbot (legacy)
Build 12504: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 22 2019, 20:45
Owners added a reviewer: Restricted Owners Package.Aug 22 2019, 20:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 22 2019, 20:45
teamcity added a comment.Aug 22 2019, 20:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.Aug 22 2019, 20:47
teamcity added a comment.Aug 22 2019, 20:53

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7230: Diff 10932.Aug 22 2019, 20:53
Fabien accepted this revision.Aug 23 2019, 09:38
This revision is now accepted and ready to land.Aug 23 2019, 09:38
Closed by commit rABCe26ef4b479c4: Merge #11131: rpc: Write authcookie atomically (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 23 2019, 19:05
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCe26ef4b479c4: Merge #11131: rpc: Write authcookie atomically.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGe26ef4b479c4: Merge #11131: rpc: Write authcookie atomically.Sep 19 2019, 01:59

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines
22 lines

Diff 10932

View Options

src/rpc/protocol.h

Loading...
View Options

src/rpc/protocol.cpp

Loading...