Page MenuHomePhabricator
Differential D3938

use base58 map instead of strchr()
ClosedPublic
Actions

Authored by fpelliccioni on Aug 22 2019, 19:36.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING7b0d5028a6b5: use base58 map instead of strchr()
rABC7b0d5028a6b5: use base58 map instead of strchr()
Summary

Backport of Bitcoin Core PR12704
https://github.com/bitcoin/bitcoin/pull/12704

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-ad823178e
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7234
Build 12513: Bitcoin ABC Buildbot (legacy)
Build 12512: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Aug 22 2019, 19:36
Owners added a reviewer: Restricted Owners Package.Aug 22 2019, 19:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 22 2019, 19:36
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 22 2019, 19:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 22 2019, 19:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7228: Diff 10928.Aug 22 2019, 19:43
Fabien requested changes to this revision.Aug 23 2019, 13:49
Fabien added inline comments.
src/base58.cpp
54 ↗(On Diff #10928)

Move the comment in its own line above.

58 ↗(On Diff #10928)

Dito + add braces:

// Invalid b58 character
if (carry == -1) {
    return false;
}
This revision now requires changes to proceed.Aug 23 2019, 13:49
fpelliccioni updated this revision to Diff 10949.Aug 26 2019, 13:55

Fixed comments and braces

teamcity added a comment.Aug 26 2019, 13:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 26 2019, 14:02

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7234: Diff 10949.Aug 26 2019, 14:02
Fabien accepted this revision.Aug 26 2019, 14:21
This revision is now accepted and ready to land.Aug 26 2019, 14:21
Closed by commit rABC7b0d5028a6b5: use base58 map instead of strchr() (authored by Kevin Pan <bit.kevin@gmail.com>, committed by fpelliccioni). · Explain WhyAug 26 2019, 14:23
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC7b0d5028a6b5: use base58 map instead of strchr().
fpelliccioni added a commit: rSTAGING7b0d5028a6b5: use base58 map instead of strchr().Sep 19 2019, 02:00

Revision Contents
Changeset List

PathSize
src/
26 lines
test/
data/
4 lines

Diff 10949

View Options

src/base58.cpp

Loading...
View Options

src/test/data/base58_encode_decode.json

Loading...