Page MenuHomePhabricator
Differential D4017

Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...)
ClosedPublic
Actions

Authored by fpelliccioni on Sep 6 2019, 16:35.

Details

Reviewers
Fabien
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING4210ed4fcc0e: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid…
rABC4210ed4fcc0e: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid…
Summary

Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...).

Backport of Bitcoin Core PR14242
https://github.com/bitcoin/bitcoin/pull/14242

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-6fc656a41
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7347
Build 12737: Bitcoin ABC Buildbot (legacy)
Build 12736: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 6 2019, 16:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2019, 16:35
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 6 2019, 16:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B7347: Diff 11135!Sep 6 2019, 16:52
teamcity added a comment.Sep 6 2019, 16:52

Build Bitcoin-ABC / Diffs / Diff Testing failed.

teamcity added a comment.Sep 6 2019, 17:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Sep 6 2019, 17:25
This revision is now accepted and ready to land.Sep 6 2019, 17:25
teamcity added a comment.Sep 6 2019, 17:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7347: Diff 11135.Sep 6 2019, 17:32
Closed by commit rABC4210ed4fcc0e: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by fpelliccioni). · Explain WhySep 11 2019, 19:46
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC4210ed4fcc0e: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid….
fpelliccioni added a commit: rSTAGING4210ed4fcc0e: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid….Sep 19 2019, 02:16

Revision Contents
Changeset List

PathSize
src/
4 lines

Diff 11135

View Options

src/key_io.cpp

Loading...