Page MenuHomePhabricator
Differential D4028

[CMAKE] Move version to the top level CMakeLists.txt
ClosedPublic
Actions

Authored by Fabien on Sep 10 2019, 15:54.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING4981eef18df0: [CMAKE] Move version to the top level CMakeLists.txt
rABC4981eef18df0: [CMAKE] Move version to the top level CMakeLists.txt
Summary

Apart from making it easier to figure out where it is located, it will
also avoid duplicating it when using CPack.

Depends on D4027.

Test Plan
ninja

Check the version is correct:

./src/bitcoind --version
./src/qt/bitcoin-qt --version
./src/bitcoin-cli --version
./src/bitcoin-tx -h

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_version_toplevel
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7380
Build 12803: Bitcoin ABC Buildbot (legacy)
Build 12802: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 10 2019, 15:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2019, 15:54
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 10 2019, 15:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 10 2019, 16:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7376: Diff 11178.Sep 10 2019, 16:07
jasonbcox requested changes to this revision.Sep 10 2019, 19:54
jasonbcox added a subscriber: jasonbcox.

release-process.md needs updating

This revision now requires changes to proceed.Sep 10 2019, 19:54
Fabien updated this revision to Diff 11185.Sep 11 2019, 06:27

Update the release process doc.

teamcity added a comment.Sep 11 2019, 06:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7380: Diff 11185.Sep 11 2019, 06:35
teamcity added a comment.Sep 11 2019, 06:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Sep 11 2019, 11:56
jasonbcox accepted this revision.Sep 11 2019, 16:46
This revision is now accepted and ready to land.Sep 11 2019, 16:46
Closed by commit rABC4981eef18df0: [CMAKE] Move version to the top level CMakeLists.txt (authored by Fabien). · Explain WhySep 11 2019, 19:16
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4981eef18df0: [CMAKE] Move version to the top level CMakeLists.txt.
Fabien added a commit: rSTAGING4981eef18df0: [CMAKE] Move version to the top level CMakeLists.txt.Sep 19 2019, 02:15

Revision Contents
Changeset List

PathSize
7 lines
doc/
2 lines
src/
config/
8 lines

Diff 11185

View Options

CMakeLists.txt

Loading...
View Options

doc/release-process.md

Loading...
View Options

src/config/CMakeLists.txt

Loading...