Page MenuHomePhabricator
Differential D4046

Merge #13399: rpc: Add submitheader
ClosedPublic
Actions

Authored by jasonbcox on Sep 11 2019, 21:07.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING0d917a7b964a: Merge #13399: rpc: Add submitheader
rABC0d917a7b964a: Merge #13399: rpc: Add submitheader
Summary

fa091b001605c4481fb4eca415929a98d3478549 qa: Add tests for submitheader (MarcoFalke)
36b1b63f20cc718084971d2cadd04497a9b72634 rpc: Expose ProcessNewBlockHeaders (MarcoFalke)

Pull request description:

This exposes `ProcessNewBlockHeaders` as an rpc called `submitheader`. This can be used to check for invalid block headers and submission of valid block headers via the rpc.

Tree-SHA512: a61e850470f15465f88e450609116df0a98d5d9afadf36b2033d820933d8b6a4012f9f2b3246319c08a0e511bef517f5d808cd0f44ffca91d10895a938004f0b

Backport of Core PR13399
https://github.com/bitcoin/bitcoin/pull/13399/files
Completes T685
Depends on D3856

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13399
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7421
Build 12885: Bitcoin ABC Buildbot (legacy)
Build 12884: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 11 2019, 21:07
Herald added a reviewer: deadalnix. · View Herald TranscriptSep 11 2019, 21:07
teamcity added a comment.Sep 11 2019, 21:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 11 2019, 21:16

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7405: Diff 11226.Sep 11 2019, 21:16
jasonbcox added a child revision: D4047: Merge #13983: rpc: Return more specific reject reason for submitblock.Sep 11 2019, 21:16
Fabien requested changes to this revision.Sep 12 2019, 06:27
Fabien added a subscriber: Fabien.

Code looks good, but this deserves a release note.

This revision now requires changes to proceed.Sep 12 2019, 06:27
jasonbcox updated this revision to Diff 11244.Sep 12 2019, 15:42

Added a release note.

teamcity added a comment.Sep 12 2019, 15:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 12 2019, 15:49

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7421: Diff 11244!Sep 12 2019, 15:49
teamcity added a comment.Sep 12 2019, 19:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7421: Diff 11244.Sep 12 2019, 19:13
teamcity added a comment.Sep 12 2019, 19:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Sep 12 2019, 19:18
This revision is now accepted and ready to land.Sep 12 2019, 19:18
Closed by commit rABC0d917a7b964a: Merge #13399: rpc: Add submitheader (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhySep 12 2019, 20:25
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC0d917a7b964a: Merge #13399: rpc: Add submitheader.
jasonbcox added a commit: rSTAGING0d917a7b964a: Merge #13399: rpc: Add submitheader.Sep 19 2019, 02:17

Revision Contents
Changeset List

PathSize
doc/
1 line
src/
2 lines
15 lines
rpc/
44 lines
test/
functional/
95 lines

Diff 11244

View Options

doc/release-notes.md

Loading...
View Options

src/core_io.h

Loading...
View Options

src/core_read.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

test/functional/mining_basic.py

Loading...