Page MenuHomePhabricator
Differential D4058

[SECP256K1] Create a different library when building with JNI
ClosedPublic
Actions

Authored by Fabien on Sep 12 2019, 16:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING9ff97e0fd3fc: [SECP256K1] Create a different library when building with JNI
rABC9ff97e0fd3fc: [SECP256K1] Create a different library when building with JNI
Summary

The current behavior is to build a secp256k1 library that has the JNI
binding feature if enabled.
This diff keeps the main secp256k1 library intact, and creates another
secp256k1_jni library with JNI support in it. The java test is updated
to reflect this.

Depends on D4053.

Test Plan
cd secp256k1
./autogen.sh
mkdir build && cd build
../configure --enable-jni --enable-experimental --enable-module-ecdh
make

Check there is a libsecp256k1_jni.so file under .libs/

make check-java

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1_jni_lib
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7463
Build 12969: Bitcoin ABC Buildbot (legacy)
Build 12968: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 12 2019, 16:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2019, 16:42
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 12 2019, 16:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 12 2019, 16:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7429: Diff 11254.Sep 12 2019, 16:50
Fabien added a child revision: D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.Sep 12 2019, 19:46
Fabien mentioned this in D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.Sep 12 2019, 19:47
deadalnix requested changes to this revision.Sep 13 2019, 08:10
deadalnix added inline comments.
src/secp256k1/Makefile.am
9 ↗(On Diff #11254)

It doesn't look like this is necessary anymore.

This revision now requires changes to proceed.Sep 13 2019, 08:10
Fabien updated this revision to Diff 11315.Sep 14 2019, 16:00

Cleanup the obsolete variable.

teamcity added a comment.Sep 14 2019, 16:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 14 2019, 16:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7463: Diff 11315.Sep 14 2019, 16:08
deadalnix accepted this revision.Sep 14 2019, 17:07
This revision is now accepted and ready to land.Sep 14 2019, 17:07
Closed by commit rABC9ff97e0fd3fc: [SECP256K1] Create a different library when building with JNI (authored by Fabien). · Explain WhySep 14 2019, 17:13
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC9ff97e0fd3fc: [SECP256K1] Create a different library when building with JNI.
Fabien added a commit: rSTAGING9ff97e0fd3fc: [SECP256K1] Create a different library when building with JNI.Sep 19 2019, 02:22

Revision Contents
Changeset List

PathSize
src/
secp256k1/
13 lines
src/
java/
org/
bitcoin/
2 lines

Diff 11315

View Options

src/secp256k1/Makefile.am

Loading...
View Options

src/secp256k1/src/java/org/bitcoin/Secp256k1Context.java

Loading...