Page MenuHomePhabricator
Differential D4077

[qt] Replaces numbered place marker %2 with %1.
ClosedPublic
Actions

Authored by fpelliccioni on Sep 13 2019, 22:28.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2d6763dd0b83: [qt] Replaces numbered place marker %2 with %1.
rABC2d6763dd0b83: [qt] Replaces numbered place marker %2 with %1.
Summary

This PR closes #12015 in which @chen610620 suggests to replace numbered place marker %2 with %1.

Backport of Bitcoin Core PR12092
https://github.com/bitcoin/bitcoin/pull/12092

Test Plan
make
./src/qt/bitcoin-qt -regtest
  1. Open the "Send" dialog.
  2. Enter a BCH testnet address.
  3. Enter a valid amount.
  4. Press "Send" button, at bottom.
  5. Check that the confirmation message is Ok.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-fd4ca1736
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7493
Build 13029: Bitcoin ABC Buildbot (legacy)
Build 13028: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 13 2019, 22:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2019, 22:28
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 13 2019, 22:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7453: Diff 11303.Sep 13 2019, 22:36
teamcity added a comment.Sep 13 2019, 22:36

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix requested changes to this revision.Sep 14 2019, 07:55

Test plan

This revision now requires changes to proceed.Sep 14 2019, 07:55
fpelliccioni edited the test plan for this revision. (Show Details)Sep 17 2019, 16:11
fpelliccioni updated this revision to Diff 11366.Sep 17 2019, 16:14
fpelliccioni edited the test plan for this revision. (Show Details)

test plan updated.

teamcity added a comment.Sep 17 2019, 16:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 17 2019, 16:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7493: Diff 11366.Sep 17 2019, 16:32
deadalnix accepted this revision.Sep 17 2019, 17:56
This revision is now accepted and ready to land.Sep 17 2019, 17:56
Closed by commit rABC2d6763dd0b83: [qt] Replaces numbered place marker %2 with %1. (authored by fpelliccioni). · Explain WhySep 20 2019, 12:36
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC2d6763dd0b83: [qt] Replaces numbered place marker %2 with %1..
fpelliccioni added a commit: rSTAGING2d6763dd0b83: [qt] Replaces numbered place marker %2 with %1..Sep 27 2019, 22:45

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines

Diff 11366

View Options

src/qt/sendcoinsdialog.cpp

Loading...