Page MenuHomePhabricator
Differential D4005

cli: Ignore libevent warnings
ClosedPublic
Actions

Authored by fpelliccioni on Sep 5 2019, 19:07.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING50ae4433e7af: cli: Ignore libevent warnings
rABC50ae4433e7af: cli: Ignore libevent warnings
Summary

Should fix rpc tests that fail due to an unclean stderr.

Backport of Bitcoin Core PR13394
https://github.com/bitcoin/bitcoin/pull/13394

Test Plan

In a macOS terminal:

./src/bitcoind -regtest

In another macOS terminal:

./src/bitcoin-cli -regtest help

The following warning should not be seen in stdout/stderr:
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D4005
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7496
Build 13035: Bitcoin ABC Buildbot (legacy)
Build 13034: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 5 2019, 19:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2019, 19:07
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 5 2019, 19:07

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 5 2019, 19:16

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7330: Diff 11104.Sep 5 2019, 19:16
Fabien requested changes to this revision.Sep 6 2019, 07:06

The code looks good but the test plan is unappropriated.
Can you check that the error occurs before the patch and no longer after ?

src/bitcoin-cli.cpp
113 ↗(On Diff #11104)

Move comment above

This revision now requires changes to proceed.Sep 6 2019, 07:06
fpelliccioni edited the test plan for this revision. (Show Details)Sep 17 2019, 18:53
fpelliccioni edited the test plan for this revision. (Show Details)
fpelliccioni updated this revision to Diff 11370.Sep 17 2019, 18:56

updated test plan.

teamcity added a comment.Sep 17 2019, 18:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 17 2019, 19:11

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7496: Diff 11370.Sep 17 2019, 19:11
deadalnix requested changes to this revision.Sep 17 2019, 20:08
deadalnix added inline comments.
src/bitcoin-cli.cpp
114

Put the comment before the #define

This revision now requires changes to proceed.Sep 17 2019, 20:08
fpelliccioni updated this revision to Diff 11385.Sep 18 2019, 18:13

Code style: comment moved.

teamcity added a comment.Sep 18 2019, 18:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7502: Diff 11385.Sep 18 2019, 18:29
teamcity added a comment.Sep 18 2019, 18:29

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Sep 19 2019, 08:15
Fabien accepted this revision.Sep 20 2019, 05:54
This revision is now accepted and ready to land.Sep 20 2019, 05:54
Closed by commit rABC50ae4433e7af: cli: Ignore libevent warnings (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by fpelliccioni). · Explain WhyOct 7 2019, 20:50
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC50ae4433e7af: cli: Ignore libevent warnings.
fpelliccioni added a commit: rSTAGING50ae4433e7af: cli: Ignore libevent warnings.Oct 9 2019, 20:12

Revision Contents
Changeset List

PathSize
src/
13 lines

Diff 11370

View Options

src/bitcoin-cli.cpp

Loading...