Merge #13383: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...)
AbandonedPublic
Actions

Authored by nakihito on Sep 18 2019, 21:10.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

f41d339b781f41f05946e965da3e1bf5d0a9e50b bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...) (practicalswift)

Pull request description:

Non-Boost is better than Boost.
Non-throwing is better than throwing.
Explicit error handling is better than implicit error handling.
ParseDouble(…) deserves to be used outside of its unit tests :-)

Tree-SHA512: a8cf04a5f8363cb7ced0bcaf1fed00e1e5dd6a63a6c11e5f0ba4e5c845b0df7c2b050d887075f158cd62dc7e02843ecaafc15e42e383c066461c6d7399e06b49

Backport of Core PR13383
https://github.com/bitcoin/bitcoin/pull/13383/

Test Plan

make check
bench/bench_bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13383

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7504
Build 13051: Bitcoin ABC Buildbot (legacy)
Build 13050: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 18 2019, 21:10

Owners added a reviewer: Restricted Owners Package.Sep 18 2019, 21:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 18 2019, 21:10

nakihito planned changes to this revision.Sep 18 2019, 21:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito requested review of this revision.Sep 18 2019, 21:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7504: Diff 11388.Sep 18 2019, 21:20

This is a duplicate of D4080

See D4080.

Revision Contents
Changeset List

Path

Size

src/

bench/

bench_bitcoin.cpp

10 lines

Diff 11388

View Options

src/bench/bench_bitcoin.cpp

Merge #13383: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...)AbandonedPublicActions