Page MenuHomePhabricator
Differential D472

Fixed overflow in GetPerformanceCounter()
ClosedPublic
Actions

Authored by CCulianu on Aug 15 2017, 01:54.

Details

Reviewers
freetrader
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING65987b1ab815: Fixed overflow in GetPerformanceCounter()
rABC65987b1ab815: Fixed overflow in GetPerformanceCounter()
Summary

I ran UBSAN on the tests and this was one of the easier fixes. Bitcoin compiles as a 32-bit app and as such this usage ends up with an overflow. Note that this bug isn't super-critical as the GetPerformanceCounter() function is only used to seed random number generators, but it still is a bug nonetheless.

Test Plan

make check and rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixrandom
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 731
Build 731: arc lint + arc unit

Event Timeline

CCulianu created this revision.Aug 15 2017, 01:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2017, 01:54
CCulianu updated this revision to Diff 1178.Aug 15 2017, 08:09

Modified to be minimally required expression syntax to have all types auto-promoted to int64

deadalnix accepted this revision.Aug 15 2017, 21:17
This revision is now accepted and ready to land.Aug 15 2017, 21:17
Closed by commit rABC65987b1ab815: Fixed overflow in GetPerformanceCounter() (authored by CCulianu, committed by CCulianu). · Explain WhyAug 15 2017, 22:57
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 1176

View Options

src/random.cpp

Loading...