Page MenuHomePhabricator
Differential D4119

Merge #13201: [qa] Handle disconnect_node race
ClosedPublic
Actions

Authored by nakihito on Sep 20 2019, 20:33.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING15971bd1f20a: Merge #13201: [qa] Handle disconnect_node race
rABC15971bd1f20a: Merge #13201: [qa] Handle disconnect_node race
Summary

09c6699900 [qa] Handle disconnect_node race (Suhas Daftuar)

Pull request description:

Several tests call disconnect_nodes() on each node-pair in rapid
succession, resulting in a race condition if a node disconnects a peer
in-between the calculation of the nodeid's to disconnect and the
invocation of the disconnectnode rpc call.  Handle this.

Tree-SHA512: 3078cea0006fcb507c812004a777c505eb1e9dda7c6df12dbbe72395a73ff6f6760f597b6492054f5487b34534417ddef5fbad30553c135c288c4b7cfce79223

Backport of Core PR13201
https://github.com/bitcoin/bitcoin/pull/13201/

Test Plan
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13201
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7529
Build 13098: Bitcoin ABC Buildbot (legacy)
Build 13097: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 20 2019, 20:33
Owners added a reviewer: Restricted Owners Package.Sep 20 2019, 20:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2019, 20:33
nakihito planned changes to this revision.Sep 20 2019, 20:33
teamcity added a comment.Sep 20 2019, 20:34

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7529: Diff 13042.Sep 20 2019, 20:44
teamcity added a comment.Sep 20 2019, 20:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito requested review of this revision.Sep 23 2019, 20:29
jasonbcox accepted this revision.Sep 23 2019, 21:51

Macro likestamp:

This revision is now accepted and ready to land.Sep 23 2019, 21:51
Closed by commit rABC15971bd1f20a: Merge #13201: [qa] Handle disconnect_node race (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhySep 24 2019, 01:00
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC15971bd1f20a: Merge #13201: [qa] Handle disconnect_node race.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING15971bd1f20a: Merge #13201: [qa] Handle disconnect_node race.Sep 27 2019, 22:48

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
9 lines

Diff 13042

View Options

test/functional/test_framework/util.py

Loading...