Page MenuHomePhabricator
Differential D4132

refactor: Use boost::scoped_connection in signal/slot, also prefer range-based loop instead of std::transform
ClosedPublic
Actions

Authored by deadalnix on Sep 22 2019, 11:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING6615be98b28e: refactor: Use boost::scoped_connection in signal/slot, also prefer range-based…
rABC6615be98b28e: refactor: Use boost::scoped_connection in signal/slot, also prefer range-based…
Summary

This is a partial backport of Core PR13743 : https://github.com/bitcoin/bitcoin/pull/13743/commits/2196c51821e340c9a9d2c76c30f9402370f84994

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
refactorscoped
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7543
Build 13126: Bitcoin ABC Buildbot (legacy)
Build 13125: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 22 2019, 11:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2019, 11:09
teamcity added a comment.Sep 22 2019, 11:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 22 2019, 11:19

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7543: Diff 13059.Sep 22 2019, 11:19
deadalnix added a child revision: D4133: scripted-diff: Replace boost::bind with std::bind.Sep 22 2019, 11:35
Fabien accepted this revision.Sep 23 2019, 07:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validationinterface.cpp
68

Nit: has to be

This revision is now accepted and ready to land.Sep 23 2019, 07:59
Closed by commit rABC6615be98b28e: refactor: Use boost::scoped_connection in signal/slot, also prefer range-based… (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by deadalnix). · Explain WhySep 23 2019, 10:57
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC6615be98b28e: refactor: Use boost::scoped_connection in signal/slot, also prefer range-based….
deadalnix added a commit: rSTAGING6615be98b28e: refactor: Use boost::scoped_connection in signal/slot, also prefer range-based….Sep 27 2019, 22:47

Revision Contents
Changeset List

PathSize
src/
rpc/
8 lines
8 lines
94 lines

Diff 13059

View Options

src/rpc/server.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/validationinterface.cpp

Loading...