Page MenuHomePhabricator
Differential D4141

Fix compiler warnings emitted when compiling under stock OpenBSD 6.3
ClosedPublic
Actions

Authored by fpelliccioni on Sep 23 2019, 21:14.

Details

Reviewers
Fabien
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGb5e2c50e1509: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3
rABCb5e2c50e1509: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3
Summary

Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 (OpenBSD clang version 5.0.1, based on LLVM 5.0.1):

Backport of Bitcoin Core PR13294
https://github.com/bitcoin/bitcoin/pull/13294

Test Plan

make check-all is OK on my platform (Linux 5.2.15-200.fc30.x86_64 x86_64)

I don't have an OpenBSD 6.3 to test it.
It doesn't seem that the changes are going to have problems on it.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-26c93edf1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7557
Build 13154: Bitcoin ABC Buildbot (legacy)
Build 13153: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 23 2019, 21:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2019, 21:14
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 23 2019, 21:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni edited the test plan for this revision. (Show Details)Sep 23 2019, 21:18
teamcity added a comment.Sep 23 2019, 21:24

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7557: Diff 13092.Sep 23 2019, 21:24
jasonbcox accepted this revision.Sep 23 2019, 21:56
This revision is now accepted and ready to land.Sep 23 2019, 21:56
Closed by commit rABCb5e2c50e1509: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by fpelliccioni). · Explain WhySep 24 2019, 12:56
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABCb5e2c50e1509: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3.
fpelliccioni added a commit: rSTAGINGb5e2c50e1509: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3.Sep 27 2019, 22:48

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 13092

View Options

src/txmempool.cpp

Loading...