Avoid locking mutexes that are already held by the same thread. These are reentrant mutexes, but still no need to lock them more than once per thread :-)
Backport of Bitcoin Core PR11762
https://github.com/bitcoin/bitcoin/pull/11762
Details
Details
- Reviewers
Fabien deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGINGed346d416fd1: Avoid locking mutexes that are already held by the same thread
rABCed346d416fd1: Avoid locking mutexes that are already held by the same thread
- Build with Clang in Debug mode:
CXX=clang++ CC=clang cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug ninja check
- Verify that the compiler has not emitted a thread-safety warning.
- Run the node: ./src/bitcoind -regtest
- Verify that text similar to "Assertion failed: lock ... not held ..." is not printed on stderr.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- arcpatch-D4145
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 7608 Build 13256: Bitcoin ABC Buildbot (legacy) Build 13255: arc lint + arc unit
Event Timeline
Comment Actions
The test plan is not apropriate. You need to test with clang to make sure the thread anotation are repsected, (gcc doesn't support this) and run the test suite on a debug build to check that AssertLockHeld doesn't trigger.