Make SignatureData able to store signatures and scripts
ClosedPublic
Actions

Authored by deadalnix on Oct 4 2019, 00:42.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGae1211c395eb: Make SignatureData able to store signatures and scripts
rABCae1211c395eb: Make SignatureData able to store signatures and scripts

Summary

In addition to having the scriptSig and scriptWitness, have SignatureData
also be able to store just the signatures (pubkeys mapped to sigs) and
scripts (script ids mapped to scripts).

Also have DataFromTransaction be able to extract signatures and scripts
from the scriptSig and scriptWitness of an input to put them in SignatureData.

Adds a new SignatureChecker which takes a SignatureData and puts pubkeys
and signatures into it when it successfully verifies a signature.

Adds a new field in SignatureData which stores whether the SignatureData
was complete. This allows us to also update the scriptSig and
scriptWitness to the final one when updating a SignatureData with another
one.

This is a partial backport of Core PR13425 : https://github.com/bitcoin/bitcoin/pull/13425/commits/0422beb9bdfcd7d1cc095ab681a760d8bc7a1918

Also include a change to the transction validation cache that erroneously resused stale sigdata.

Depends on D4209 and D4203

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

SignatureDatastore

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7686
Build 13411: Bitcoin ABC Buildbot (legacy)
Build 13410: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 4 2019, 00:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2019, 00:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7686: Diff 13348.Oct 4 2019, 00:57

deadalnix added a child revision: D4211: Replace CombineSignatures with ProduceSignature.Oct 4 2019, 01:03

Fabien accepted this revision.Oct 4 2019, 08:59

This revision is now accepted and ready to land.Oct 4 2019, 08:59

Closed by commit rABCae1211c395eb: Make SignatureData able to store signatures and scripts (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 4 2019, 21:51

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCae1211c395eb: Make SignatureData able to store signatures and scripts.

deadalnix added a commit: rSTAGINGae1211c395eb: Make SignatureData able to store signatures and scripts.Oct 9 2019, 20:11

Revision Contents
Changeset List

Path

Size

src/

bitcoin-tx.cpp

5 lines

rpc/

rawtransaction.cpp

6 lines

script/

sign.h

19 lines

sign.cpp

130 lines

test/

transaction_tests.cpp

26 lines

txvalidationcache_tests.cpp

29 lines

Diff 13348

View Options

src/bitcoin-tx.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/script/sign.h

View Options

src/script/sign.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

Make SignatureData able to store signatures and scriptsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13348

src/bitcoin-tx.cpp

src/rpc/rawtransaction.cpp

src/script/sign.h

src/script/sign.cpp

src/test/transaction_tests.cpp

src/test/txvalidationcache_tests.cpp

Make SignatureData able to store signatures and scripts
ClosedPublic
Actions

Revision Contents
Changeset List