Page MenuHomePhabricator

Replace CombineSignatures with ProduceSignature
ClosedPublic

Authored by deadalnix on Oct 4 2019, 01:03.

Details

Summary

Instead of using CombineSignatures to create the final scriptSig or
scriptWitness of an input, use ProduceSignature itself.

To allow for ProduceSignature to place signatures, pubkeys, and scripts
that it does not know about, we pass down the SignatureData to SignStep
which pulls out the information that it needs from the SignatureData.

This is a partial backport of Core PR13425 : https://github.com/bitcoin/bitcoin/pull/13425/commits/ed94c8b556dbbfb62452eaefd9ee7841df09777a

Depends on D4205 and D4210

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
producesig
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7687
Build 13413: Bitcoin ABC Buildbot (legacy)
Build 13412: arc lint + arc unit