Add pubkeys and whether input was witness to SignatureData
ClosedPublic
Actions

Authored by deadalnix on Oct 23 2019, 16:46.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING9bbebfb295ae: Add pubkeys and whether input was witness to SignatureData
rABC9bbebfb295ae: Add pubkeys and whether input was witness to SignatureData

Summary

Stores pubkeys in SignatureData and retrieves them when using GetPubKey().

Stores whether the signatures in a SignatureData are for a witness input.

This is a partial backport of Core PR13557 : https://github.com/bitcoin/bitcoin/pull/13557/commits/12bcc64f277f642ece03c25653e726f2276f0d51

Depends on D4258

Test Plan

Unfortunately, The PR dump all the tests at once at the end, so there are n test for the new code.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pubkeypbst

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7849
Build 13718: Bitcoin ABC Buildbot (legacy)
Build 13717: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 23 2019, 16:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2019, 16:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Oct 23 2019, 16:48

deadalnix added a parent revision: D4258: Implement PSBT Structures and un/serialization methods per BIP 174.

deadalnix added a child revision: D4286: Methods for interacting with PSBT structs.Oct 23 2019, 16:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7849: Diff 13665.Oct 23 2019, 17:02

jasonbcox accepted this revision.Oct 23 2019, 18:18

This revision is now accepted and ready to land.Oct 23 2019, 18:18

Closed by commit rABC9bbebfb295ae: Add pubkeys and whether input was witness to SignatureData (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 30 2019, 17:29

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC9bbebfb295ae: Add pubkeys and whether input was witness to SignatureData.

deadalnix added a commit: rSTAGING9bbebfb295ae: Add pubkeys and whether input was witness to SignatureData.Apr 7 2020, 21:32

Revision Contents
Changeset List

Path

Size

src/

script/

sign.h

1 line

sign.cpp

16 lines

Diff 13665

View Options

src/script/sign.h