qt: Use new Qt5 connect syntax
AbandonedPublic
Actions

Authored by nakihito on Oct 29 2019, 20:18.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

qt: Use new Qt5 connect syntax

Upgrades the gui code from using Qt4 SIGNAL/SLOT syntax to Qt5's new
syntax.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28

Depends on D4304

Test Plan

make check
./bitcoin-qt

Open literally every window and menu

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7898
Build 13806: Bitcoin ABC Buildbot (legacy)
Build 13805: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 29 2019, 20:18

Owners added a reviewer: Restricted Owners Package.Oct 29 2019, 20:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2019, 20:18

nakihito planned changes to this revision.Oct 29 2019, 20:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7898: Diff 13747.Oct 29 2019, 20:29

nakihito added a child revision: D4306: test: Add lint to prevent SIGNAL/SLOT connect style.Oct 29 2019, 20:34

nakihito edited the summary of this revision. (Show Details)Oct 29 2019, 20:39

nakihito removed a child revision: D4306: test: Add lint to prevent SIGNAL/SLOT connect style.Oct 31 2019, 20:48

Landed as numerous smaller changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

addressbookpage.cpp

41 lines

askpassphrasedialog.cpp

16 lines

bitcoin.cpp

63 lines

bitcoinamountfield.cpp

13 lines

bitcoingui.h

12 lines

bitcoingui.cpp

177 lines

clientmodel.cpp

2 lines

coincontroldialog.cpp

75 lines

20 lines

9 lines

3 lines

99 lines

28 lines

21 lines

2 lines

qvalidatedlineedit.cpp

3 lines

qvaluecombobox.cpp

6 lines

receivecoinsdialog.cpp

30 lines

receiverequestdialog.cpp

13 lines

recentrequeststablemodel.cpp

4 lines

5 lines

112 lines

120 lines

26 lines

test/

paymentservertests.cpp

9 lines

trafficgraphwidget.cpp

2 lines

transactiontablemodel.cpp

4 lines

98 lines

8 lines

3 lines

82 lines

Diff 13747

View Options

src/qt/addressbookpage.cpp

View Options

src/qt/askpassphrasedialog.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoinamountfield.cpp

View Options

src/qt/bitcoingui.h

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/clientmodel.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/intro.cpp

View Options

src/qt/modaloverlay.cpp

View Options

src/qt/optionsdialog.cpp

View Options

src/qt/overviewpage.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/peertablemodel.cpp

View Options

src/qt/qvalidatedlineedit.cpp

View Options

src/qt/qvaluecombobox.cpp

View Options

src/qt/receivecoinsdialog.cpp

View Options

src/qt/receiverequestdialog.cpp

View Options

src/qt/recentrequeststablemodel.cpp

View Options

src/qt/rpcconsole.h

View Options

src/qt/rpcconsole.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/sendcoinsentry.cpp

View Options

src/qt/test/paymentservertests.cpp

View Options

src/qt/trafficgraphwidget.cpp

View Options

src/qt/transactiontablemodel.cpp

View Options

src/qt/transactionview.cpp

View Options

src/qt/walletframe.cpp

View Options

src/qt/walletmodel.cpp

View Options

qt: Use new Qt5 connect syntaxAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13747

src/qt/addressbookpage.cpp

src/qt/askpassphrasedialog.cpp

src/qt/bitcoin.cpp

src/qt/bitcoinamountfield.cpp

src/qt/bitcoingui.h

src/qt/bitcoingui.cpp

src/qt/clientmodel.cpp

src/qt/coincontroldialog.cpp

src/qt/guiutil.cpp

src/qt/intro.cpp

src/qt/modaloverlay.cpp

src/qt/optionsdialog.cpp

src/qt/overviewpage.cpp

src/qt/paymentserver.cpp

src/qt/peertablemodel.cpp

src/qt/qvalidatedlineedit.cpp

src/qt/qvaluecombobox.cpp

src/qt/receivecoinsdialog.cpp

src/qt/receiverequestdialog.cpp

src/qt/recentrequeststablemodel.cpp

src/qt/rpcconsole.h

src/qt/rpcconsole.cpp

src/qt/sendcoinsdialog.cpp

src/qt/sendcoinsentry.cpp

src/qt/test/paymentservertests.cpp

src/qt/trafficgraphwidget.cpp

src/qt/transactiontablemodel.cpp

src/qt/transactionview.cpp

src/qt/walletframe.cpp

src/qt/walletmodel.cpp

src/qt/walletview.cpp

qt: Use new Qt5 connect syntax
AbandonedPublic
Actions

Revision Contents
Changeset List