Page MenuHomePhabricator
Differential D4307

Update qt/addressbookpage.cpp to use Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 29 2019, 21:03.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc3d483f62997: Update qt/addressbookpage.cpp to use Qt5 connect syntax
rABCc3d483f62997: Update qt/addressbookpage.cpp to use Qt5 connect syntax
Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28

Test Plan
make check
./bitcoin-qt
File -> Sending addresses
File -> Receiving Addresses

Try every button, open every sub menu, and left and right click on addresses for both menus.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13529-3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7901
Build 13812: Bitcoin ABC Buildbot (legacy)
Build 13811: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 29 2019, 21:03
Owners added a reviewer: Restricted Owners Package.Oct 29 2019, 21:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2019, 21:03
teamcity added a comment.Oct 29 2019, 21:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 29 2019, 21:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7901: Diff 13756.Oct 29 2019, 21:13
nakihito retitled this revision from Update addressbookpage.cpp to use Qt5 connect syntax to Update qt/addressbookpage.cpp to use Qt5 connect syntax.Oct 29 2019, 21:16
jasonbcox accepted this revision.Oct 29 2019, 21:46
This revision is now accepted and ready to land.Oct 29 2019, 21:46
Closed by commit rABCc3d483f62997: Update qt/addressbookpage.cpp to use Qt5 connect syntax (authored by nakihito). · Explain WhyOct 29 2019, 21:57
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCc3d483f62997: Update qt/addressbookpage.cpp to use Qt5 connect syntax.
nakihito added a commit: rSTAGINGc3d483f62997: Update qt/addressbookpage.cpp to use Qt5 connect syntax.Apr 7 2020, 21:31

Revision Contents
Changeset List

PathSize
src/
qt/
41 lines

Diff 13756

View Options

src/qt/addressbookpage.cpp

Loading...