Update qt/walletmodel.cpp with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 31 2019, 18:41.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING0b02b3ab49da: Update qt/walletmodel.cpp with Qt5 connect syntax
rABC0b02b3ab49da: Update qt/walletmodel.cpp with Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-2e3836af182cfb375329c3463ffd91f8

Test Plan

make check
./bitcoin-qt
Send -> Receive -> Transactions

Verify each sub menu loads correctly.

Help -> Debug -> Console
createwallet test

Switch to the new wallet in both the console and the main window
In the console:

getwalletinfo

In the mainwindow:

Overview -> Send -> Receive -> Transactions

Verify the main window loadseach sub menu correctly.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7943
Build 13889: Bitcoin ABC Buildbot (legacy)
Build 13888: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 31 2019, 18:41

Owners added a reviewer: Restricted Owners Package.Oct 31 2019, 18:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2019, 18:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7939: Diff 13836.Oct 31 2019, 19:10

Fabien accepted this revision.Oct 31 2019, 20:10

This revision is now accepted and ready to land.Oct 31 2019, 20:10

nakihito mentioned this in D4345: Update qt/walletmodel.cpp with Qt5 connect syntax.Oct 31 2019, 20:12

Rebased and removed dependency.

nakihito removed a parent revision: D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.Oct 31 2019, 20:27

nakihito edited the summary of this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7943: Diff 13845.Oct 31 2019, 21:12

Closed by commit rABC0b02b3ab49da: Update qt/walletmodel.cpp with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 21:13

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC0b02b3ab49da: Update qt/walletmodel.cpp with Qt5 connect syntax.

nakihito added a commit: rSTAGING0b02b3ab49da: Update qt/walletmodel.cpp with Qt5 connect syntax.Apr 7 2020, 21:34

Revision Contents
Changeset List

Path

Size

src/

qt/

walletmodel.cpp

3 lines

Diff 13845

View Options

Update qt/walletmodel.cpp with Qt5 connect syntaxClosedPublicActions