paymentservertests.cpp to use Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 31 2019, 21:38.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING7b315185cc0d: Update qt/test/paymentservertests.cpp to use Qt5 connect syntax
rABC7b315185cc0d: Update qt/test/paymentservertests.cpp to use Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-86ee984762bcf229d495727d769c156b

Test Plan

make check
src/qt/test/test_bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7947
Build 13897: Bitcoin ABC Buildbot (legacy)
Build 13896: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 31 2019, 21:38

Owners added a reviewer: Restricted Owners Package.Oct 31 2019, 21:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2019, 21:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7947: Diff 13852.Oct 31 2019, 21:48

jasonbcox accepted this revision.Oct 31 2019, 22:04

This revision is now accepted and ready to land.Oct 31 2019, 22:04

Closed by commit rABC7b315185cc0d: Update qt/test/paymentservertests.cpp to use Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 22:11

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC7b315185cc0d: Update qt/test/paymentservertests.cpp to use Qt5 connect syntax.

nakihito added a commit: rSTAGING7b315185cc0d: Update qt/test/paymentservertests.cpp to use Qt5 connect syntax.Apr 7 2020, 21:34

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

paymentservertests.cpp

9 lines

Diff 13852

View Options

src/qt/test/paymentservertests.cpp

Update qt/test/paymentservertests.cpp to use Qt5 connect syntaxClosedPublicActions