Page MenuHomePhabricator
Differential D4419

Modify CSeederNode to allow more testing
AbandonedPublic
Actions

Authored by nakihito on Nov 9 2019, 01:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Loosen the API a little bit to allow for testing without completely
destroying encapsulation.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
FormatBitcoincpph
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8042
Build 14079: Bitcoin ABC Buildbot (legacy)
Build 14078: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 9 2019, 01:14
Owners added a reviewer: Restricted Owners Package.Nov 9 2019, 01:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2019, 01:14
teamcity added a comment.Nov 9 2019, 01:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 9 2019, 01:30

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8042: Diff 14021.Nov 9 2019, 01:30
deadalnix added a comment.Nov 10 2019, 17:40

You can include this with the test. It's not really possible to figure out if that is a good idea or not without having an idea of where this is going.

Fabien requested changes to this revision.Nov 12 2019, 07:31

Agreed with @deadalnix, clearing my queue.

This revision now requires changes to proceed.Nov 12 2019, 07:31
nakihito abandoned this revision.Nov 13 2019, 01:14

See D4436.

Revision Contents
Changeset List

PathSize
src/
seeder/
5 lines

Diff 14021

View Options

src/seeder/bitcoin.h

Loading...