[CMAKE] Avoid dependencies when building native bin during cross build
ClosedPublic
Actions

Authored by Fabien on Nov 11 2019, 11:51.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGc37e7cb11251: [CMAKE] Avoid dependencies when building native bin during cross build
rABCc37e7cb11251: [CMAKE] Avoid dependencies when building native bin during cross build

Summary

The NativeExecutable.cmake module will run CMake from the top level
with all the default options, leading to some dependencies being
required while they is no use for it.
This will remove the need for most host side dependencies when running
the gitian builds with CMake.

Test Plan

ninja check

Cross build for any platform.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_remove_native_dependencies

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8055
Build 14105: Bitcoin ABC Buildbot (legacy)
Build 14104: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 11 2019, 11:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2019, 11:51

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.Nov 11 2019, 11:52

Fabien added a child revision: D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.Nov 11 2019, 11:55

Harbormaster completed remote builds in B8055: Diff 14045.Nov 11 2019, 12:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien added a child revision: D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.Nov 11 2019, 12:13

jasonbcox accepted this revision.Nov 11 2019, 22:47

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

cmake/modules/NativeExecutable.cmake
18	nit: what initially threw me off was that these were any dependencies. after clarifying offline, I think the comment could be clarified to state that this is to reduce unneeded third-party dependencies specifically.

This revision is now accepted and ready to land.Nov 11 2019, 22:47

Improve comment.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B8071: Diff 14068!Nov 12 2019, 09:25

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8071: Diff 14068.Nov 12 2019, 09:47

Closed by commit rABCc37e7cb11251: [CMAKE] Avoid dependencies when building native bin during cross build (authored by Fabien). · Explain WhyNov 13 2019, 07:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc37e7cb11251: [CMAKE] Avoid dependencies when building native bin during cross build.

Fabien removed a child revision: D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.Nov 13 2019, 14:41