The NativeExecutable.cmake module will run CMake from the top level
with all the default options, leading to some dependencies being
required while they is no use for it.
This will remove the need for most host side dependencies when running
the gitian builds with CMake.
Details
Details
- Reviewers
deadalnix jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGINGc37e7cb11251: [CMAKE] Avoid dependencies when building native bin during cross build
rABCc37e7cb11251: [CMAKE] Avoid dependencies when building native bin during cross build
ninja check
Cross build for any platform.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cmake_remove_native_dependencies
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8071 Build 14132: Bitcoin ABC Buildbot (legacy) Build 14131: arc lint + arc unit
Event Timeline
| cmake/modules/NativeExecutable.cmake | ||
|---|---|---|
| 18 ↗ | (On Diff #14045) | nit: what initially threw me off was that these were any dependencies. after clarifying offline, I think the comment could be clarified to state that this is to reduce unneeded third-party dependencies specifically. |