Page MenuHomePhabricator

[CI] Add a new build configuration to run tests with cmake and ninja
ClosedPublic

Authored by Fabien on Nov 14 2019, 10:34.

Details

Summary

The build-check-all configuration runs the check-all target. The
additional cmake flags allow to run the secp256k1 Java tests.

Depends on D4443.

Test Plan
export ABC_BUILD_NAME=build-check-all
./contrib/teamcity/build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ci_check_all
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

contrib/teamcity/build_cmake.sh
15 ↗(On Diff #14126)

git clean -xffd or similar is probably a better approach.

Fabien planned changes to this revision.Nov 14 2019, 14:31
Fabien added inline comments.
contrib/teamcity/build_cmake.sh
15 ↗(On Diff #14126)

I didn't know git clean, thanks!

Use git clean to cleanup to build directory.

jasonbcox requested changes to this revision.Nov 14 2019, 22:49
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/build_cmake.sh
15 ↗(On Diff #14126)

TIL about git clean

But won't this affect the entire source tree, not just the build dir? If I'm working on a change in this file (or others) and I run build_cmake.sh, won't it blow away all of my changes? I don't think that's the intent here.

This revision now requires changes to proceed.Nov 14 2019, 22:49
Fabien requested review of this revision.Nov 14 2019, 23:02
Fabien added inline comments.
contrib/teamcity/build_cmake.sh
15 ↗(On Diff #14126)

It only affects files under the current directory, and there is a cd to the build dir before the git clean call so it will only remove your files if they are under the build directory.

jasonbcox added inline comments.
contrib/teamcity/build_cmake.sh
15 ↗(On Diff #14126)

I misinterpreted the man page. Thanks for clarifying.

This revision is now accepted and ready to land.Nov 14 2019, 23:23