Page MenuHomePhabricator
Differential D4433

[github-release] Add optional param to specify release notes path
ClosedPublic
Actions

Authored by jasonbcox on Nov 12 2019, 19:19.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGcfc48b787dae: [github-release] Add optional param to specify release notes path
rABCcfc48b787dae: [github-release] Add optional param to specify release notes path
Summary

The script breaks if the version bump has not been applied yet.
This decouples the need to bump the version number from releasing.

Test Plan
git clone https://github.com/bitcoin-abc/bitcoin-abc.git
./github-release.sh -o <path/to/oauth-token> -t v0.20.6 -a <path/to/0.20.6-binaries/> -d  # fails
./github-release.sh -o <path/to/oauth-token> -t v0.20.6 -a <path/to/0.20.6-binaries/> -r ~/bitcoin-abc/doc/release-notes.md -d  # succeeds

Diff Detail

Repository
rABC Bitcoin ABC
Branch
github-release-notes
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

jasonbcox created this revision.Nov 12 2019, 19:19
Herald added a reviewer: deadalnix. · View Herald TranscriptNov 12 2019, 19:19
jasonbcox planned changes to this revision.Nov 12 2019, 19:19
teamcity added a comment.Nov 12 2019, 19:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B8077: Diff 14077.Nov 12 2019, 19:28
teamcity added a comment.Nov 12 2019, 19:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox requested review of this revision.Nov 12 2019, 19:29
jasonbcox edited the test plan for this revision. (Show Details)
jasonbcox updated this revision to Diff 14135.Nov 14 2019, 22:19

Rebase

teamcity added a comment.Nov 14 2019, 22:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 14 2019, 22:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 14 2019, 22:29

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Nov 14 2019, 22:29

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8116: Diff 14135.Nov 14 2019, 22:29
jasonbcox updated this revision to Diff 14137.Nov 14 2019, 22:51

test update please ignore

teamcity added a comment.Nov 14 2019, 22:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 14 2019, 22:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox added a comment.Nov 14 2019, 22:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox added a comment.Nov 14 2019, 22:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 14 2019, 23:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8118: Diff 14137.Nov 14 2019, 23:01
teamcity added a comment.Nov 14 2019, 23:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Nov 14 2019, 23:02

Build Bitcoin-ABC / Diffs / Diff Testing failed.

teamcity added a comment.Nov 14 2019, 23:02

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Fabien accepted this revision.Nov 18 2019, 08:35
This revision is now accepted and ready to land.Nov 18 2019, 08:35
This revision was landed with ongoing or failed builds.Nov 18 2019, 18:16
Closed by commit rABCcfc48b787dae: [github-release] Add optional param to specify release notes path (authored by jasonbcox). · Explain Why
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCcfc48b787dae: [github-release] Add optional param to specify release notes path.
jasonbcox added a commit: rSTAGINGcfc48b787dae: [github-release] Add optional param to specify release notes path.Apr 7 2020, 21:42

Revision Contents
Changeset List

PathSize
contrib/
devtools/
15 lines

Diff 14137

View Options

contrib/devtools/github-release.sh

Loading...