Page MenuHomePhabricator

[github-release] Add optional param to specify release notes path
ClosedPublic

Authored by jasonbcox on Nov 12 2019, 19:19.

Details

Summary

The script breaks if the version bump has not been applied yet.
This decouples the need to bump the version number from releasing.

Test Plan
git clone https://github.com/bitcoin-abc/bitcoin-abc.git
./github-release.sh -o <path/to/oauth-token> -t v0.20.6 -a <path/to/0.20.6-binaries/> -d  # fails
./github-release.sh -o <path/to/oauth-token> -t v0.20.6 -a <path/to/0.20.6-binaries/> -r ~/bitcoin-abc/doc/release-notes.md -d  # succeeds

Diff Detail

Repository
rABC Bitcoin ABC
Branch
github-release-notes
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

jasonbcox edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Nov 18 2019, 08:35
This revision was landed with ongoing or failed builds.Nov 18 2019, 18:16
This revision was automatically updated to reflect the committed changes.