Page MenuHomePhabricator
Differential D4481

Remove obj_c for macOS Dock icon menu
ClosedPublic
Actions

Authored by Fabien on Nov 20 2019, 09:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING129d118f1245: Remove obj_c for macOS Dock icon menu
rABC129d118f1245: Remove obj_c for macOS Dock icon menu
Summary
Qt `setAsDockMenu()` does this work.

Partial backport of core PR14123 (commit 6b1d297):
https://github.com/bitcoin/bitcoin/pull/14123/commits/6b1d2972bf9a40f97ba3a5c95831fd179b1054cf

Depends on D4480.

Test Plan

Build and run bitcoin-qt for macOS.
Check the docked icon works as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14123_part3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8171
Build 14371: Default Diff Build & Tests
Build 14370: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 20 2019, 09:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 09:04
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 20 2019, 09:32

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4482: qt: Add GUIUtil::bringToFront.Nov 20 2019, 09:33
teamcity added a comment.Nov 20 2019, 09:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8171: Diff 14223.Nov 20 2019, 09:47
deadalnix accepted this revision.Nov 20 2019, 14:10
This revision is now accepted and ready to land.Nov 20 2019, 14:10
Fabien updated this revision to Diff 14243.Nov 20 2019, 16:33

Rebase

This revision was landed with ongoing or failed builds.Nov 20 2019, 16:34
Closed by commit rABC129d118f1245: Remove obj_c for macOS Dock icon menu (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC129d118f1245: Remove obj_c for macOS Dock icon menu.
teamcity added a comment.Nov 20 2019, 16:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 20 2019, 17:02

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8184: Diff 14243.Nov 20 2019, 17:02
Fabien added a commit: rSTAGING129d118f1245: Remove obj_c for macOS Dock icon menu.Apr 7 2020, 21:44

Revision Contents
Changeset List

PathSize
src/
qt/
3 lines
11 lines
20 lines

Diff 14223

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/macdockiconhandler.h

Loading...
View Options

src/qt/macdockiconhandler.mm

Loading...