Differential D4482

qt: Add GUIUtil::bringToFront
ClosedPublic
Actions

Authored by Fabien on Nov 20 2019, 09:33.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING0174f7544c1e: qt: Add GUIUtil::bringToFront
rABC0174f7544c1e: qt: Add GUIUtil::bringToFront

Summary

The sequence show -> raise -> activateWindow is factored out to the new
function GUIUtil::bringToFront where a macOS fix is added in order to
fix #13829.

Partial backport of core PR14123 (commit 5796671)
https://github.com/bitcoin/bitcoin/pull/14123/commits/5796671e1dd8a2d0b1e750c2dce19a10af624095

Depends on D4481.

Test Plan

Build and run bitcoin-qt on OSX and Linux.
Check the dock icon is working as expected.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14123_part4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8172
Build 14373: Default Diff Build & Tests
Build 14372: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 20 2019, 09:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 09:33

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Nov 20 2019, 09:37

Fabien added inline comments.

src/qt/guiutil.cpp
65	See D556.

Likely due to our clang-format rule for not add indent in a namespace, git managed to cleanly merge the method in the header at the wrong place while showing no conflict.
This is something we need to pay attention in the future.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8172: Diff 14224.Nov 20 2019, 09:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4483: qt: Use GUIUtil::bringToFront where possible.Nov 20 2019, 09:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8173: Diff 14225.Nov 20 2019, 10:01

deadalnix accepted this revision.Nov 20 2019, 14:11

This revision is now accepted and ready to land.Nov 20 2019, 14:11

Closed by commit rABC0174f7544c1e: qt: Add GUIUtil::bringToFront (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyNov 20 2019, 16:35

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0174f7544c1e: qt: Add GUIUtil::bringToFront.

Fabien added a commit: rSTAGING0174f7544c1e: qt: Add GUIUtil::bringToFront.Apr 7 2020, 21:44