Page MenuHomePhabricator
Differential D4480

Use Qt signal for macOS Dock icon click event
ClosedPublic
Actions

Authored by Fabien on Nov 20 2019, 08:38.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING21430eccd373: Use Qt signal for macOS Dock icon click event
rABC21430eccd373: Use Qt signal for macOS Dock icon click event
Summary
This moves the Dock icon click reaction code to the common place and
allows some cleanup in obj_c code.

According to the Apple's docs `class_replaceMethod` behaves as
`class_addMethod`, if the method identified by name does not yet exist;
or as `method_setImplementation`, if it does exist.

Partial backport of core PR14123 (commit ):
https://github.com/bitcoin/bitcoin/pull/14123/commits/2464925e7be832d4926b6204169bbbc1646c6368

Test Plan

Build and run on OSX.
Check the dock icon is working as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14123_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8181
Build 14391: Default Diff Build & Tests
Build 14390: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 20 2019, 08:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 08:38
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 20 2019, 08:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 20 2019, 08:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8169: Diff 14217.Nov 20 2019, 08:48
Fabien edited the summary of this revision. (Show Details)Nov 20 2019, 08:49
Fabien removed a parent revision: D4472: Remove obj_c for macOS Dock icon setting.
Fabien updated this revision to Diff 14222.Nov 20 2019, 08:49

Rebase.

Fabien added a child revision: D4481: Remove obj_c for macOS Dock icon menu.Nov 20 2019, 09:04
teamcity added a comment.Nov 20 2019, 09:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 20 2019, 09:34

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8170: Diff 14222.Nov 20 2019, 09:34
deadalnix accepted this revision.Nov 20 2019, 14:09
deadalnix added inline comments.
src/qt/macdockiconhandler.h
15 ↗(On Diff #14222)

Fix layout

This revision is now accepted and ready to land.Nov 20 2019, 14:09
Fabien updated this revision to Diff 14238.Nov 20 2019, 16:22

Rebase and fix layout

teamcity added a comment.Nov 20 2019, 16:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

This revision was landed with ongoing or failed builds.Nov 20 2019, 16:29
Closed by commit rABC21430eccd373: Use Qt signal for macOS Dock icon click event (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC21430eccd373: Use Qt signal for macOS Dock icon click event.
teamcity added a comment.Nov 20 2019, 16:36

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8181: Diff 14238.Nov 20 2019, 16:36
Fabien added a commit: rSTAGING21430eccd373: Use Qt signal for macOS Dock icon click event.Apr 7 2020, 21:44

Revision Contents
Changeset List

PathSize
src/
qt/
3 lines
24 lines
9 lines
44 lines

Diff 14238

View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/macdockiconhandler.h

Loading...
View Options

src/qt/macdockiconhandler.mm

Loading...