Page MenuHomePhabricator
Differential D4491

Implement key origin lookup in CWallet
ClosedPublic
Actions

Authored by deadalnix on Nov 20 2019, 16:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGf3f969bc3917: Implement key origin lookup in CWallet
rABCf3f969bc3917: Implement key origin lookup in CWallet
Summary

This is a partial backport of Core PR13723 : https://github.com/bitcoin/bitcoin/pull/13723/commits/03a99586a398ee38f40c3b72d24c6a2ba4b88579

Depends on D4488 and D4490

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
implementkeyoriginlookup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8183
Build 14395: Default Diff Build & Tests
Build 14394: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 20 2019, 16:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2019, 16:30
teamcity added a comment.Nov 20 2019, 16:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 20 2019, 16:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8183: Diff 14242.Nov 20 2019, 16:55
deadalnix added a child revision: D4493: Pass HD path data through SignatureData.Nov 20 2019, 17:43
deadalnix updated this revision to Diff 14275.Nov 20 2019, 21:40

Rebase and fix merge conflict

teamcity added a comment.Nov 20 2019, 22:01

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 20 2019, 22:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8201: Diff 14275.Nov 20 2019, 22:17
Fabien accepted this revision.Nov 21 2019, 20:02
This revision is now accepted and ready to land.Nov 21 2019, 20:02
Closed by commit rABCf3f969bc3917: Implement key origin lookup in CWallet (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyNov 21 2019, 23:09
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCf3f969bc3917: Implement key origin lookup in CWallet.
deadalnix added a commit: rSTAGINGf3f969bc3917: Implement key origin lookup in CWallet.Apr 7 2020, 21:47

Revision Contents
Changeset List

PathSize
src/
wallet/
23 lines
5 lines
28 lines

Diff 14242

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...