Page MenuHomePhabricator
Differential D4524

[tests] Remove 'account' API from wallet_listtransactions
ClosedPublic
Actions

Authored by nakihito on Nov 23 2019, 02:59.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8ab8cbc1d8ee: [tests] Remove 'account' API from wallet_listtransactions
rABC8ab8cbc1d8ee: [tests] Remove 'account' API from wallet_listtransactions
Summary

Removes usage of account API from the following functional tests:

  • wallet_listtransactions.py

Partial backport of Core PR13075
https://github.com/bitcoin/bitcoin/pull/13075/commits/5d536619abda745c298fd827a856df775f223241#diff-b8f2524f5de4f960040a44c6c7611b70

Test Plan
test_runnery.py wallet_listtransactions

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13075-5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8249
Build 14523: Default Diff Build & Tests
Build 14522: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 23 2019, 02:59
Owners added a reviewer: Restricted Owners Package.Nov 23 2019, 02:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2019, 02:59
teamcity added a comment.Nov 23 2019, 02:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 23 2019, 03:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8249: Diff 14350.Nov 23 2019, 03:08
deadalnix accepted this revision.Nov 23 2019, 15:02
This revision is now accepted and ready to land.Nov 23 2019, 15:02
nakihito retitled this revision from [tests] Remove 'account' API from wallet_listtransacions to [tests] Remove 'account' API from wallet_listtransactions.Nov 25 2019, 18:20
Closed by commit rABC8ab8cbc1d8ee: [tests] Remove 'account' API from wallet_listtransactions (authored by nakihito). · Explain WhyNov 25 2019, 18:22
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC8ab8cbc1d8ee: [tests] Remove 'account' API from wallet_listtransactions.
nakihito added a commit: rSTAGING8ab8cbc1d8ee: [tests] Remove 'account' API from wallet_listtransactions.Apr 7 2020, 21:50

Revision Contents
Changeset List

PathSize
test/
functional/
30 lines

Diff 14350

View Options

test/functional/wallet_listtransactions.py

Loading...