Page MenuHomePhabricator
Differential D4568

Merge #15149: gui: Show current wallet name in window title
ClosedPublic
Actions

Authored by jasonbcox on Nov 27 2019, 20:23.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING0e28ecba8ec1: Merge #15149: gui: Show current wallet name in window title
rABC0e28ecba8ec1: Merge #15149: gui: Show current wallet name in window title
Summary

fe7048b39 gui: Show current wallet name in window title (João Barbosa)
8a7926112 gui: Keep network style in BitcoinGUI (João Barbosa)
f411c8b35 gui: Remove unused return type in some BitcoinGUI methods (João Barbosa)

Pull request description:

<img width="876" alt="screenshot 2019-01-11 at 23 58 26" src="https://user-images.githubusercontent.com/3534524/51065458-d7ebaf80-15fc-11e9-9162-e37e9a10d448.png">

Tree-SHA512: 5c43f615834983bc1c5045e07c6e119044dd78ca947fd2679d302b519d5ce1d08d29ca00b1c11e88c4bbc4d56f2e6f4a8adc42084f3503e751e642e8a13112dc

Backport of Core PR15149
https://github.com/bitcoin/bitcoin/pull/15149/files

Depends on D4567
Completes T699

Test Plan

ninja check
Verify bitcoin-qt shows wallet name in window title.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15149
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8316
Build 14651: Default Diff Build & Tests
Build 14650: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 27 2019, 20:23
Herald added a reviewer: deadalnix. · View Herald TranscriptNov 27 2019, 20:23
jasonbcox edited the test plan for this revision. (Show Details)Nov 27 2019, 20:24
Fabien accepted this revision.Nov 27 2019, 20:42
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/bitcoingui.cpp
76 ↗(On Diff #14470)

Nit: put config before platform to keep ordering consistent

This revision is now accepted and ready to land.Nov 27 2019, 20:42
teamcity added a comment.Nov 27 2019, 21:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 27 2019, 21:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8314: Diff 14470.Nov 27 2019, 21:46
jasonbcox updated this revision to Diff 14474.Nov 27 2019, 21:52
  • Rebase
  • changed member initializer ordering per feedback
  • removed enableWallet(false) which was erroneously left in D1959
teamcity added a comment.Nov 27 2019, 21:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 27 2019, 22:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8316: Diff 14474.Nov 27 2019, 22:08
Fabien accepted this revision.Nov 28 2019, 06:34
Closed by commit rABC0e28ecba8ec1: Merge #15149: gui: Show current wallet name in window title (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by jasonbcox). · Explain WhyNov 28 2019, 16:07
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC0e28ecba8ec1: Merge #15149: gui: Show current wallet name in window title.
jasonbcox added a commit: rSTAGING0e28ecba8ec1: Merge #15149: gui: Show current wallet name in window title.Apr 7 2020, 21:54

Revision Contents
Changeset List

PathSize
src/
qt/
14 lines
63 lines
3 lines
7 lines

Diff 14474

View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/walletframe.h

Loading...
View Options

src/qt/walletframe.cpp

Loading...