Page MenuHomePhabricator
Differential D4570

Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal
ClosedPublic
Actions

Authored by majcosta on Nov 27 2019, 23:02.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGeb1893c84752: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal
rABCeb1893c84752: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal
Summary

This is a backport of Core PR14728

As above. https://github.com/bitcoin/bitcoin/pull/14728

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
second-backport
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8320
Build 14659: Default Diff Build & Tests
Build 14658: arc lint + arc unit

Event Timeline

majcosta created this revision.Nov 27 2019, 23:02
Owners added a reviewer: Restricted Owners Package.Nov 27 2019, 23:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2019, 23:02
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 27 2019, 23:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix requested changes to this revision.Nov 27 2019, 23:11
deadalnix added inline comments.
src/netaddress.h
34 ↗(On Diff #14475)

Revert

73 ↗(On Diff #14475)

dito

This revision now requires changes to proceed.Nov 27 2019, 23:11
teamcity added a comment.Nov 27 2019, 23:16

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8317: Diff 14475.Nov 27 2019, 23:16
majcosta updated this revision to Diff 14477.Nov 27 2019, 23:37

reverted inline comments

teamcity added a comment.Nov 27 2019, 23:37

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix accepted this revision.Nov 27 2019, 23:39
This revision is now accepted and ready to land.Nov 27 2019, 23:39
deadalnix edited the summary of this revision. (Show Details)Nov 27 2019, 23:40

Keep in mind to mention PR12354936 in the diff sum up so people can grep for it easily.

You can also indent commands with double space rather than use backticks.

like this
majcosta updated this revision to Diff 14479.Nov 27 2019, 23:42

removed declaration not in our codebase

teamcity added a comment.Nov 27 2019, 23:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

majcosta edited the test plan for this revision. (Show Details)Nov 27 2019, 23:45
teamcity added a comment.Nov 27 2019, 23:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8319: Diff 14477.Nov 27 2019, 23:55
teamcity added a comment.Nov 27 2019, 23:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8320: Diff 14479.Nov 27 2019, 23:58
Closed by commit rABCeb1893c84752: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyNov 28 2019, 00:35
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCeb1893c84752: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.
majcosta added a commit: rSTAGINGeb1893c84752: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.Apr 7 2020, 21:54

Revision Contents
Changeset List

PathSize
src/
2 lines
1 line
test/
41 lines

Diff 14479

View Options

src/netaddress.h

Loading...
View Options

src/netaddress.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...