Differential D4575

Nit in net_processing.cpp
ClosedPublic
Actions

Authored by deadalnix on Nov 28 2019, 17:49.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGf5ffef56ba54: Nit in net_processing.cpp
rABCf5ffef56ba54: Nit in net_processing.cpp

Summary

There is no point taking the txid, putting it in a CInv, and then reconstructing the TxId using the CInv.

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

netprocnits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8326
Build 14671: Default Diff Build & Tests
Build 14670: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 28 2019, 17:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2019, 17:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

rebase

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8325: Diff 14490.Nov 28 2019, 18:09

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8326: Diff 14492.Nov 28 2019, 18:23

deadalnix retitled this revision from Nit in ne_processing.cpp to Nit in net_processing.cpp.Nov 28 2019, 19:40

Fabien accepted this revision.Nov 28 2019, 20:13

This revision is now accepted and ready to land.Nov 28 2019, 20:13

Closed by commit rABCf5ffef56ba54: Nit in net_processing.cpp (authored by deadalnix). · Explain WhyNov 28 2019, 21:54

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf5ffef56ba54: Nit in net_processing.cpp.

deadalnix added a commit: rSTAGINGf5ffef56ba54: Nit in net_processing.cpp.Apr 7 2020, 21:54

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

4 lines

Diff 14492

View Options

Nit in net_processing.cppClosedPublicActions