Update mempool's mapTx to index from TxId.
ClosedPublic
Actions

Authored by deadalnix on Nov 30 2019, 21:00.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING8a300d51d9c3: Update mempool's mapTx to index from TxId.
rABC8a300d51d9c3: Update mempool's mapTx to index from TxId.

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mempooltxid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8354
Build 14727: Default Diff Build & Tests
Build 14726: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 30 2019, 21:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2019, 21:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8354: Diff 14537.Nov 30 2019, 21:16

deadalnix added a child revision: D4599: Update mempool's mapDelta to use TxId.Nov 30 2019, 21:22

Fabien accepted this revision.Dec 2 2019, 08:32

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/txmempool.cpp
449	Nit: `phash` could be `pTxId`

This revision is now accepted and ready to land.Dec 2 2019, 08:32

Closed by commit rABC8a300d51d9c3: Update mempool's mapTx to index from TxId. (authored by deadalnix). · Explain WhyDec 2 2019, 14:28

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC8a300d51d9c3: Update mempool's mapTx to index from TxId..

deadalnix added a commit: rSTAGING8a300d51d9c3: Update mempool's mapTx to index from TxId..Apr 7 2020, 21:57

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

20 lines

mining.cpp

4 lines

test/

blockencodings_tests.cpp

16 lines

txmempool.h

18 lines

txmempool.cpp

30 lines

validation.cpp

4 lines

Diff 14537

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/blockencodings_tests.cpp

View Options

src/txmempool.h

View Options

src/txmempool.cpp

View Options

Update mempool's mapTx to index from TxId.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14537

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/test/blockencodings_tests.cpp

src/txmempool.h

src/txmempool.cpp

src/validation.cpp

Update mempool's mapTx to index from TxId.
ClosedPublic
Actions

Revision Contents
Changeset List