Page MenuHomePhabricator

tx pool: Use class methods to hide raw map iterator impl details
ClosedPublic

Authored by deadalnix on Nov 30 2019, 22:30.

Details

Summary

This is a backport of Core PR13793

Depends on D4599

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Nov 30 2019, 22:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2019, 22:30
Fabien accepted this revision.Dec 2 2019, 08:06
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/txmempool.h
672 ↗(On Diff #14540)

Update to comment to avoid confusion (hash -> txid)

677 ↗(On Diff #14540)

Dito

This revision is now accepted and ready to land.Dec 2 2019, 08:06